fix: Adds missing hover zoom animation to CTA arrow, makes CTA arrow a shared resource between components#861
Merged
curlyfriesplease merged 6 commits intomasterfrom Mar 30, 2026
Merged
Conversation
…ared resource between components
curlyfriesplease
changed the title
AndyEPhipps
reviewed
Mar 30, 2026
| @media ${({ theme }) => theme.allBreakpoints('M')} { | ||
| &:hover { | ||
| ${ArrowIconWrapper} ${ArrowIconInner} { | ||
| transform: scale(1.1); |
Contributor
There was a problem hiding this comment.
Wooft, I can barely see a change! Was this specifically asked for? I'd check with Curtis to see if he wants it juiced a bit more
Contributor
Author
There was a problem hiding this comment.
Yeah it's comically subtle isn't it. He wanted it put in, and to match the figgers. I'll double check just to see if I can make this work feel a bit more worthwhile!
Contributor
Author
There was a problem hiding this comment.
He's on board with a juicier 20%
AndyEPhipps
approved these changes
Mar 30, 2026
Contributor
AndyEPhipps
left a comment
AndyEPhipps
left a comment
There was a problem hiding this comment.
Looking good apart from the question re: the zoom
|
🎉 This PR is included in version 8.68.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
What is it doing?
This one had a bit too much being changed to keep in the other PR I have for the general megafix ticket, ENG-4930, so I'm putting it in its own PR.
Here, this is adding a subtle 10% zoom on hover to the CTA arrow - the one that's used by CTA cards and Hero Banner.
It is added as a shared resource between these two components.
There is one difference between their implementations, with CTA cards the button's grey until hovered. In the case of Hero Banner, it's always red. This is now controlled by a transient prop called
$preventHoverColourChange.Why is this required?
Website redesign project.
link to Jira ticket:
ENG-4954
Quick Checklist:
My PR title follows the Conventional Commit spec.
I have filled out the PR description as per the template above.
I have added tests to cover new or changed behaviour.
I have updated any relevant documentation.
Important! - lastly, make sure to squash merge...