chore: add pre-commit workflow to ci for license checks#74
Closed
amoeba wants to merge 8 commits intocolumnar-tech:mainfrom
amoeba:license-check
Closed
chore: add pre-commit workflow to ci for license checks#74amoeba wants to merge 8 commits intocolumnar-tech:mainfrom amoeba:license-check
amoeba wants to merge 8 commits intocolumnar-tech:mainfrom
amoeba:license-check
Conversation
Member
Author
|
As a follow-on, we could:
|
Member
Author
|
Rebased the pr and updated the workflow. The pre-commit only checks to make sure we spell our name right at the moment. I did this assuming Apache RAT can check that the entire license is right. cc @zeroshade |
zeroshade
requested changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to #73.
Adds a new GHA workflow to run pre-commit and a pre-commit config that runs https://github.com/amoeba/license-header-check/. Includes fixes to files that were missing licenses.