Reset JSContext exception after processing#42
Merged
colinc86 merged 1 commit intocolinc86:mainfrom Apr 3, 2026
Merged
Conversation
colinc86
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation never resets the
JSContextexceptionproperty. This means that a single exception will pollute all subsequent calls to MathJaxSwift e.g.try tex2svg(input1)throwsMathJax.context.exceptionis now non-niltry tex2svg(input2)should succeed, but still throws because ofinput1exceptionThe naive fix is to reset the
context.exceptionafter checking for the current exception.