fix(lock): harden FileLock ownership semantics and lock diagnostics#504
Open
thismilktea wants to merge 1 commit into
Open
fix(lock): harden FileLock ownership semantics and lock diagnostics#504thismilktea wants to merge 1 commit into
thismilktea wants to merge 1 commit into
Conversation
…ructured lock metadata, stop treating long-held live locks as stale,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tighten FileLock ownership semantics and improve lock conflict diagnostics.
The old lock model stored only a PID and treated sufficiently old lock files as stale. That was a pragmatic recovery
path, but it seems less well suited to CodeGraph’s current usage patterns, where overlapping writer candidates (index,
watcher-driven sync, MCP, git hooks) are possible and indexing/sync duration can vary with repo size and workload.
This PR updates FileLock to:
Tests
Extended tests/security.test.ts to cover:
Also re-ran:
Tradeoff
This does give up one aggressive recovery path: a lock held by a still-alive but effectively wedged process may now
persist longer. On balance, that seems preferable here, since it avoids treating legitimate long-running writes as
stale in multi-writer scenarios.