fix(quickstart): enable batching in mass-payout.js#444
Open
Kubudak90 wants to merge 1 commit into
Open
Conversation
🟡 Heimdall Review Status
|
The original code waited for each transfer to complete inside the loop, which defeated the purpose of batching. This fix: 1. Collects all transfers first without waiting for confirmation 2. Waits for all transfers to complete in a separate loop 3. Improves performance by allowing parallel processing 4. Adds better error handling for each phase Fixes coinbase#416
Kubudak90
force-pushed
the
fix-mass-payout-batching
branch
from
f9ab429 to
c423156
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
sendMassPayoutfunction was awaiting each transfer inside the for-await loop (line 79), which prevented the SDK from batching transfers efficiently. This caused sequential processing instead of parallel execution.Solution
Changes
pendingTransfersarray to store transfer objectsTesting
This is a quickstart template change. The logic maintains the same functionality while improving performance.
Fixes #416