fix: enable batching in mass-payout.js by deferring transfer.wait()#443
Open
Kubudak90 wants to merge 1 commit into
Open
fix: enable batching in mass-payout.js by deferring transfer.wait()#443Kubudak90 wants to merge 1 commit into
Kubudak90 wants to merge 1 commit into
Conversation
The original implementation called await transfer.wait() inside the loop, which blocked each transfer from being batched. This fix: 1. Collects all transfers in an array first 2. Waits for all transfers to complete after queueing This enables proper batching and significantly improves performance when processing multiple payouts. Fixes coinbase#416
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation calls
await transfer.wait()inside the loop, which blocks each transfer from being batched. This serializes all transfers and significantly reduces throughput.Solution
This enables proper batching as the SDK can process multiple transfers concurrently.
Changes
transfersarray to store pending transfersTesting
This change maintains the same behavior while improving performance for mass payouts.
Fixes #416