Skip to content

Conversation

@Dark-Brain07
Copy link

What changed? Why?

Updated src/tests/trade_test.ts to use a distinct signed payload for the approve transaction in the broadcast test.

Why?
A TODO in the code noted that the test was using the same signed payload for both the main transaction and the approve transaction. By using a distinct payload, we verify that the broadcastTrade method correctly uses the specific approve_transaction_signed_payload and discriminates between the two.

Qualified Impact

This is a test-only change.

  • Components affected: src/tests/trade_test.ts
  • Impact of error: Incorrect test logic could lead to false positives/negatives in CI, but no production impact.
  • Resolution: Fix the test file.

@cb-heimdall
Copy link

cb-heimdall commented Jan 22, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants