test(trade): use distinct signed payload for approve transaction #439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Updated src/tests/trade_test.ts to use a distinct signed payload for the approve transaction in the
broadcasttest.Why?
A
TODOin the code noted that the test was using the same signed payload for both the main transaction and the approve transaction. By using a distinct payload, we verify that thebroadcastTrademethod correctly uses the specificapprove_transaction_signed_payloadand discriminates between the two.Qualified Impact
This is a test-only change.