Skip to content

feat: (WIP) Carousel Looping#313

Closed
hcopp wants to merge 3 commits intomasterfrom
hunter/testing-carousel
Closed

feat: (WIP) Carousel Looping#313
hcopp wants to merge 3 commits intomasterfrom
hunter/testing-carousel

Conversation

@hcopp
Copy link
Copy Markdown
Contributor

@hcopp hcopp commented Jan 20, 2026

What changed? Why?

This PR looks to bring support for looping to Carousel

Tasks

  • Don't support looping when we have only 1 page worth of content
    • We should not enable back/forward arrows or drag
  • Only clone what we need (right now it clones everything twice)
  • Cleanup web code
    • We should not include clones in ref map
  • Add doc/storybook examples
  • It is tough to manually drag from last page to first, it seems to not properly compare the values for page offsets
  • Support free drag with looping
  • Mobile

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=false

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Jan 20, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS 🟡 See below

🟡 CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 🟡 0/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants