Conversation
Collaborator
✅ Heimdall Review Status
✅
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
✅
1/1
|
Denominator calculation
|
hcopp
commented
Jan 14, 2026
| </Text> | ||
| ) : ( | ||
| label | ||
| )} |
Contributor
Author
There was a problem hiding this comment.
I am waiting to hear back from design regarding if we should add aria-hidden to the default legend item or not, since users may expect to only hear the name of each series when scrubbing.
hcopp
commented
Jan 20, 2026
| }, | ||
| ]} | ||
| yAxis={{ domain: { min: -domainLimit, max: domainLimit } }} | ||
| aria-hidden="true" |
Contributor
Author
There was a problem hiding this comment.
This example and above were interfering with screen reader since they automatically update.
hcopp
commented
Jan 20, 2026
| key: 'Combobox', | ||
| getComponent: () => | ||
| require('@coinbase/cds-mobile/alpha/combobox/__stories__/Combobox.stories').default, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
This was added when running the sync script
hcopp
commented
Jan 20, 2026
| originY={effectiveOriginY} | ||
| roundBottom={roundBottom} | ||
| roundTop={roundTop} | ||
| seriesId={seriesId} |
Contributor
Author
There was a problem hiding this comment.
This provides support for custom bar components
hcopp
commented
Jan 20, 2026
| } | ||
| ``` | ||
|
|
||
| You can use `hideBeaconLabels` to hide beacon labels, while still being able to provide a label for a series. |
Contributor
Author
There was a problem hiding this comment.
This is a nice benefit of legend, teams can still label lines without the beacon labels
cb-ekuersch
pushed a commit
that referenced
this pull request
Jan 30, 2026
* feat: chart legend * Add hideBeaconLabels * Support custom components on bar chart * Update docs * Update combobox routes * Bump version * Bump ui-mobile-playground version * Improve example accessibility * Simplify creation of legend and add a11y label * Add mobile example * Fix spread issue to dom * Update changelog * Fix changelog * Update web changelog * Improve types * Drop shape wrapper * Change LegendItem to LegendEntry * Reuse root box props * Lint * Fix lint * Bump version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR adds a new chart component, Legend.
It also adds support for hideBeaconLabels prop to Scrubber and BarComponent to BarChart.
UI changes
Mobile
Web
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false