feat: DataCard#243
Closed
adrienzheng-cb wants to merge 1 commit intoadrien/messaging-cardfrom
Closed
Conversation
adrienzheng-cb
force-pushed
the
adrien/messaging-card
branch
2 times, most recently
from
b731529 to
5b77c22
Compare
adrienzheng-cb
force-pushed
the
adrien/data-card
branch
4 times, most recently
from
a5e53aa to
5cae302
Compare
adrienzheng-cb
force-pushed
the
adrien/messaging-card
branch
from
5b77c22 to
213b21d
Compare
adrienzheng-cb
force-pushed
the
adrien/data-card
branch
from
5cae302 to
f93bbc2
Compare
adrienzheng-cb
force-pushed
the
adrien/messaging-card
branch
from
213b21d to
93d5bcf
Compare
adrienzheng-cb
force-pushed
the
adrien/data-card
branch
2 times, most recently
from
d72f1a1 to
3b8e08d
Compare
adrienzheng-cb
force-pushed
the
adrien/data-card
branch
from
3b8e08d to
d45dbeb
Compare
cb-ekuersch
reviewed
Jan 26, 2026
| showArea | ||
| accessibilityLabel="Ethereum price chart" | ||
| areaType="dotted" | ||
| height={120} |
Contributor
There was a problem hiding this comment.
nit: should DataCard restrict the size of the children vis removing the need to think about dimenstions here?
Contributor
There was a problem hiding this comment.
I could see customers wanting to place buttons below the chart which would be tough here.
| /** Layout orientation of the card. Horizontal places header and visualization side by side, vertical stacks them. */ | ||
| layout: 'horizontal' | 'vertical'; | ||
| /** child node to display as the visualization (e.g., ProgressBar or ProgressCircle). */ | ||
| children?: React.ReactNode; |
Contributor
There was a problem hiding this comment.
as we discussed in the bug bash, perhaps in the future we could consider a default visualization to show that satisfies the majority of use cases and the means to pass props through to the underlying Chart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Root cause (required for bugfixes)
UI changes
docs
storybook
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false