Fix asyncio event loop conflicts in CdpEvmWalletProvider

python/coinbase-agentkit/changelog.d/968.bugfix.md

@@ -0,0 +1 @@
+Fixed asyncio event loop conflicts in CdpEvmWalletProvider, CdpSmartWalletProvider, and CdpSolanaWalletProvider when used within existing async contexts (e.g., Jupyter notebooks, async frameworks)

python/coinbase-agentkit/coinbase_agentkit/__init__.py

@@ -42,26 +42,29 @@
 )
 
 __all__ = [
-    "AgentKit",
-    "AgentKitConfig",
     "Action",
     "ActionProvider",
-    "create_action",
-    "basename_action_provider",
-    "WalletProvider",
+    "AgentKit",
+    "AgentKitConfig",
     "CdpEvmWalletProvider",
     "CdpEvmWalletProviderConfig",
     "CdpSmartWalletProvider",
     "CdpSmartWalletProviderConfig",
     "CdpSolanaWalletProvider",
     "CdpSolanaWalletProviderConfig",
-    "EvmWalletProvider",
     "EthAccountWalletProvider",
     "EthAccountWalletProviderConfig",
+    "EvmWalletProvider",
+    "WalletProvider",
+    "X402Config",
+    "__version__",
+    "aave_action_provider",
+    "basename_action_provider",
     "cdp_api_action_provider",
     "cdp_evm_wallet_action_provider",
     "cdp_smart_wallet_action_provider",
     "compound_action_provider",
+    "create_action",
     "erc20_action_provider",
     "erc721_action_provider",
     "hyperbolic_action_provider",
@@ -76,7 +79,4 @@
     "weth_action_provider",
     "wow_action_provider",
     "x402_action_provider",
-    "X402Config",
-    "aave_action_provider",
-    "__version__",
 ]

python/coinbase-agentkit/coinbase_agentkit/action_providers/__init__.py

@@ -40,48 +40,48 @@
 from .x402.x402_action_provider import x402_action_provider, x402ActionProvider
 
 __all__ = [
+    "AaveActionProvider",
     "Action",
     "ActionProvider",
-    "create_action",
-    "AaveActionProvider",
-    "aave_action_provider",
     "BasenameActionProvider",
-    "basename_action_provider",
     "CdpApiActionProvider",
-    "cdp_api_action_provider",
     "CdpEvmWalletActionProvider",
-    "cdp_evm_wallet_action_provider",
     "CdpSmartWalletActionProvider",
-    "cdp_smart_wallet_action_provider",
     "CompoundActionProvider",
-    "compound_action_provider",
     "ERC20ActionProvider",
-    "erc20_action_provider",
     "Erc721ActionProvider",
-    "erc721_action_provider",
     "HyperbolicActionProvider",
-    "hyperbolic_action_provider",
     "MorphoActionProvider",
-    "morpho_action_provider",
     "NillionActionProvider",
-    "nillion_action_provider",
     "OnrampActionProvider",
-    "onramp_action_provider",
     "PythActionProvider",
-    "pyth_action_provider",
     "SshActionProvider",
-    "ssh_action_provider",
     "SuperfluidActionProvider",
-    "superfluid_action_provider",
     "TwitterActionProvider",
-    "twitter_action_provider",
     "WalletActionProvider",
-    "wallet_action_provider",
     "WethActionProvider",
-    "weth_action_provider",
     "WowActionProvider",
+    "X402Config",
+    "aave_action_provider",
+    "basename_action_provider",
+    "cdp_api_action_provider",
+    "cdp_evm_wallet_action_provider",
+    "cdp_smart_wallet_action_provider",
+    "compound_action_provider",
+    "create_action",
+    "erc20_action_provider",
+    "erc721_action_provider",
+    "hyperbolic_action_provider",
+    "morpho_action_provider",
+    "nillion_action_provider",
+    "onramp_action_provider",
+    "pyth_action_provider",
+    "ssh_action_provider",
+    "superfluid_action_provider",
+    "twitter_action_provider",
+    "wallet_action_provider",
+    "weth_action_provider",
     "wow_action_provider",
     "x402ActionProvider",
     "x402_action_provider",
-    "X402Config",
 ]

python/coinbase-agentkit/coinbase_agentkit/action_providers/onramp/__init__.py

@@ -4,7 +4,7 @@
 from .schemas import GetOnrampBuyUrlSchema
 
 __all__ = [
+    "GetOnrampBuyUrlSchema",
     "OnrampActionProvider",
     "onramp_action_provider",
-    "GetOnrampBuyUrlSchema",
 ]

python/coinbase-agentkit/coinbase_agentkit/action_providers/ssh/__init__.py

@@ -8,8 +8,8 @@
 
 __all__ = [
     "SSHConnection",
-    "SSHConnectionPool",
-    "SSHConnectionParams",
     "SSHConnectionError",
+    "SSHConnectionParams",
+    "SSHConnectionPool",
     "SSHKeyError",
 ]

python/coinbase-agentkit/coinbase_agentkit/action_providers/x402/__init__.py

@@ -3,4 +3,4 @@
 from .schemas import X402Config
 from .x402_action_provider import x402_action_provider
 
-__all__ = ["x402_action_provider", "X402Config"]
+__all__ = ["X402Config", "x402_action_provider"]

python/coinbase-agentkit/coinbase_agentkit/network/__init__.py

@@ -18,18 +18,18 @@
 )
 
 __all__ = [
-    "Network",
     "CHAIN_ID_TO_NETWORK_ID",
-    "NETWORK_ID_TO_CHAIN_ID",
     "NETWORK_ID_TO_CHAIN",
-    "mainnet",
-    "sepolia",
-    "base_sepolia",
+    "NETWORK_ID_TO_CHAIN_ID",
+    "Network",
+    "arbitrum",
     "arbitrum_sepolia",
-    "optimism_sepolia",
     "base",
-    "arbitrum",
+    "base_sepolia",
+    "mainnet",
     "optimism",
-    "polygon_amoy",
+    "optimism_sepolia",
     "polygon",
+    "polygon_amoy",
+    "sepolia",
 ]

python/coinbase-agentkit/coinbase_agentkit/wallet_providers/__init__.py

@@ -17,14 +17,14 @@
 from .wallet_provider import WalletProvider
 
 __all__ = [
-    "WalletProvider",
     "CdpEvmWalletProvider",
     "CdpEvmWalletProviderConfig",
     "CdpSmartWalletProvider",
     "CdpSmartWalletProviderConfig",
     "CdpSolanaWalletProvider",
     "CdpSolanaWalletProviderConfig",
-    "EvmWalletProvider",
     "EthAccountWalletProvider",
     "EthAccountWalletProviderConfig",
+    "EvmWalletProvider",
+    "WalletProvider",
 ]

python/coinbase-agentkit/coinbase_agentkit/wallet_providers/cdp_evm_wallet_provider.py

@@ -66,9 +66,9 @@ def __init__(self, config: CdpEvmWalletProviderConfig):
 
             client = self.get_client()
             if config.address:
-                account = asyncio.run(self._get_account(client, config.address))
+                account = self._run_async(self._get_account(client, config.address))
             else:
-                account = asyncio.run(self._create_account(client))
+                account = self._run_async(self._create_account(client))
 
             self._account = account
 
@@ -366,8 +366,29 @@ def _run_async(self, coroutine):
 
         """
         try:
-            loop = asyncio.get_event_loop()
+            # Check if we're in an existing event loop
+            loop = asyncio.get_running_loop()
+            # If we reach this point, there's already a running event loop
+            # We need to run the coroutine in a new thread with a new event loop
+            import concurrent.futures
+
+            def run_in_thread():
+                new_loop = asyncio.new_event_loop()
+                asyncio.set_event_loop(new_loop)
+                try:
+                    return new_loop.run_until_complete(coroutine)
+                finally:
+                    new_loop.close()
+
+            with concurrent.futures.ThreadPoolExecutor() as executor:
+                future = executor.submit(run_in_thread)
+                return future.result()
+
         except RuntimeError:
+            # No running event loop, safe to create and use a new one
             loop = asyncio.new_event_loop()
             asyncio.set_event_loop(loop)
-        return loop.run_until_complete(coroutine)
+            try:
+                return loop.run_until_complete(coroutine)
+            finally:
+                loop.close()

python/coinbase-agentkit/coinbase_agentkit/wallet_providers/cdp_smart_wallet_provider.py

@@ -96,12 +96,12 @@ async def initialize_accounts():
                             smart_account = await cdp.evm.create_smart_account(owner=owner)
                         return owner, smart_account
 
-                owner, smart_account = asyncio.run(initialize_accounts())
+                owner, smart_account = self._run_async(initialize_accounts())
                 self._address = smart_account.address
                 self._owner = owner
 
             finally:
-                asyncio.run(client.close())
+                self._run_async(client.close())
 
             self._gas_limit_multiplier = (
                 max(config.gas.gas_limit_multiplier, 1)
@@ -171,11 +171,32 @@ def _run_async(self, coroutine):
 
         """
         try:
-            loop = asyncio.get_event_loop()
+            # Check if we're in an existing event loop
+            loop = asyncio.get_running_loop()
+            # If we reach this point, there's already a running event loop
+            # We need to run the coroutine in a new thread with a new event loop
+            import concurrent.futures
+
+            def run_in_thread():
+                new_loop = asyncio.new_event_loop()
+                asyncio.set_event_loop(new_loop)
+                try:
+                    return new_loop.run_until_complete(coroutine)
+                finally:
+                    new_loop.close()
+
+            with concurrent.futures.ThreadPoolExecutor() as executor:
+                future = executor.submit(run_in_thread)
+                return future.result()
+
         except RuntimeError:
+            # No running event loop, safe to create and use a new one
             loop = asyncio.new_event_loop()
             asyncio.set_event_loop(loop)
-        return loop.run_until_complete(coroutine)
+            try:
+                return loop.run_until_complete(coroutine)
+            finally:
+                loop.close()
 
     async def _get_smart_account(self, cdp):
         """Get the smart account, handling server wallet owners differently.

python/coinbase-agentkit/coinbase_agentkit/wallet_providers/cdp_solana_wallet_provider.py

@@ -76,11 +76,11 @@ async def initialize_wallet():
                             wallet = await cdp.solana.create_account()
                         return wallet
 
-                wallet = asyncio.run(initialize_wallet())
+                wallet = self._run_async(initialize_wallet())
                 self._address = wallet.address
 
             finally:
-                asyncio.run(client.close())
+                self._run_async(client.close())
 
         except ImportError as e:
             raise ImportError(
@@ -113,11 +113,32 @@ def _run_async(self, coroutine):
 
         """
         try:
-            loop = asyncio.get_event_loop()
+            # Check if we're in an existing event loop
+            loop = asyncio.get_running_loop()
+            # If we reach this point, there's already a running event loop
+            # We need to run the coroutine in a new thread with a new event loop
+            import concurrent.futures
+
+            def run_in_thread():
+                new_loop = asyncio.new_event_loop()
+                asyncio.set_event_loop(new_loop)
+                try:
+                    return new_loop.run_until_complete(coroutine)
+                finally:
+                    new_loop.close()
+
+            with concurrent.futures.ThreadPoolExecutor() as executor:
+                future = executor.submit(run_in_thread)
+                return future.result()
+
         except RuntimeError:
+            # No running event loop, safe to create and use a new one
             loop = asyncio.new_event_loop()
             asyncio.set_event_loop(loop)
-        return loop.run_until_complete(coroutine)
+            try:
+                return loop.run_until_complete(coroutine)
+            finally:
+                loop.close()
 
     def get_address(self) -> str:
         """Get the wallet address.

python/coinbase-agentkit/tests/wallet_providers/cdp_evm_server_wallet_provider/conftest.py

@@ -135,12 +135,16 @@ def mocked_wallet_provider(mock_cdp_client, mock_account, mock_web3, mock_wallet
         network_id=MOCK_NETWORK_ID,
     )
 
-    # Patch the async run to return the mock account directly
-    with patch("asyncio.run", return_value=mock_account):
+    # Patch _run_async only during init to return the mock account
+    original_run_async = CdpEvmWalletProvider._run_async
+    CdpEvmWalletProvider._run_async = lambda self, coro: mock_account
+    try:
         provider = CdpEvmWalletProvider(config)
+    finally:
+        CdpEvmWalletProvider._run_async = original_run_async
 
-        # Manually set account and wallet attributes
-        provider._account = mock_account
-        provider._wallet = mock_wallet
+    # Manually set account and wallet attributes
+    provider._account = mock_account
+    provider._wallet = mock_wallet
 
-        yield provider
+    yield provider