Skip to content

Conversation

@vincent-cognite
Copy link
Contributor

Add support for the new maxConcurrentExecutions field on the workflow upsert endpoint. This field allows limiting the maximum number of concurrent executions for a workflow.

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@vincent-cognite
Copy link
Contributor Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the max_concurrent_executions field in workflows, allowing users to limit the number of concurrent executions. The implementation is clean and consistent across WorkflowCore, WorkflowUpsert, and Workflow data classes, with all necessary updates to initializers, _load methods, and docstrings. A corresponding integration test has been added to validate the new field during an upsert operation, ensuring the API handles it correctly. The changes adhere to the repository's style guide and best practices. Overall, this is a solid contribution with no issues found.

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.82%. Comparing base (b0eedac) to head (a656ee5).
⚠️ Report is 1 commits behind head on pysdk-release-v8.

Files with missing lines Patch % Lines
cognite/client/data_classes/workflows.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           pysdk-release-v8    #2447      +/-   ##
====================================================
+ Coverage             64.80%   64.82%   +0.01%     
====================================================
  Files                   467      467              
  Lines                 47418    47421       +3     
====================================================
+ Hits                  30731    30740       +9     
+ Misses                16687    16681       -6     
Files with missing lines Coverage Δ
tests/tests_integration/test_api/test_workflows.py 88.31% <100.00%> (+0.06%) ⬆️
cognite/client/data_classes/workflows.py 54.11% <66.66%> (+0.07%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vincent-cognite
Copy link
Contributor Author

@haakonvt
I get the policy-bot:master to complain about the number of commits here.
Something I did not setup properly?

@haakonvt
Copy link
Contributor

@haakonvt I get the policy-bot:master to complain about the number of commits here. Something I did not setup properly?

Just ignore it, it won’t block as we don’t target master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants