-
Notifications
You must be signed in to change notification settings - Fork 36
feat(workflows): add support for max_concurrent_executions field #2447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pysdk-release-v8
Are you sure you want to change the base?
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for the max_concurrent_executions field in workflows, allowing users to limit the number of concurrent executions. The implementation is clean and consistent across WorkflowCore, WorkflowUpsert, and Workflow data classes, with all necessary updates to initializers, _load methods, and docstrings. A corresponding integration test has been added to validate the new field during an upsert operation, ensuring the API handles it correctly. The changes adhere to the repository's style guide and best practices. Overall, this is a solid contribution with no issues found.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pysdk-release-v8 #2447 +/- ##
====================================================
+ Coverage 64.80% 64.82% +0.01%
====================================================
Files 467 467
Lines 47418 47421 +3
====================================================
+ Hits 30731 30740 +9
+ Misses 16687 16681 -6
🚀 New features to boost your workflow:
|
|
@haakonvt |
Just ignore it, it won’t block as we don’t target master |
Add support for the new maxConcurrentExecutions field on the workflow upsert endpoint. This field allows limiting the maximum number of concurrent executions for a workflow.