Skip to content

Conversation

@vincent-cognite
Copy link
Contributor

Added support for the new maxConcurrentExecutions field on the workflow upsert endpoint. This field allows limiting the maximum number of concurrent executions for a workflow.

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@vincent-cognite vincent-cognite changed the title CDF-26407: add support for max_concurrent_executions for data workflows feat(workflows): add support for max_concurrent_executions field Jan 21, 2026
@vincent-cognite
Copy link
Contributor Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully adds support for the max_concurrent_executions field to workflows. The changes are well-integrated into the existing data classes and tested. However, there are a few areas for improvement regarding code style and docstring clarity, specifically related to the length of __init__ methods and redundant phrases in docstrings. Adhering to the repository's style guide for 'Type Safety' and 'Readability' will further enhance the codebase.

@haakonvt
Copy link
Contributor

Please target v8 instead, you can branch out of pysdk-release-v8

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.84%. Comparing base (197a140) to head (1b6cfbd).

Files with missing lines Patch % Lines
cognite/client/data_classes/workflows.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2446      +/-   ##
==========================================
- Coverage   48.85%   48.84%   -0.01%     
==========================================
  Files         191      191              
  Lines       26149    26150       +1     
==========================================
- Hits        12776    12774       -2     
- Misses      13373    13376       +3     
Files with missing lines Coverage Δ
cognite/client/data_classes/workflows.py 53.87% <66.66%> (+0.07%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants