-
Notifications
You must be signed in to change notification settings - Fork 36
feat(workflows): add support for max_concurrent_executions field #2446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In preparation for `8.0.0a4`
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request successfully adds support for the max_concurrent_executions field to workflows. The changes are well-integrated into the existing data classes and tested. However, there are a few areas for improvement regarding code style and docstring clarity, specifically related to the length of __init__ methods and redundant phrases in docstrings. Adhering to the repository's style guide for 'Type Safety' and 'Readability' will further enhance the codebase.
|
Please target |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2446 +/- ##
==========================================
- Coverage 48.85% 48.84% -0.01%
==========================================
Files 191 191
Lines 26149 26150 +1
==========================================
- Hits 12776 12774 -2
- Misses 13373 13376 +3
🚀 New features to boost your workflow:
|
1b6cfbd to
a656ee5
Compare
Added support for the new maxConcurrentExecutions field on the workflow upsert endpoint. This field allows limiting the maximum number of concurrent executions for a workflow.