Skip to content

Conversation

@coffeemakingtoaster
Copy link
Owner

@coffeemakingtoaster coffeemakingtoaster commented Jun 23, 2025

Closes #1

This comment was marked as outdated.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces parsing support for multiple assignment in the ARG instruction by refactoring the parser to populate a key-value map and updating reconstruction and tests accordingly.

  • Changed ARG instruction representation from single name/value fields to a map of key-value pairs.
  • Updated tests to validate the new output format and adjusted reconstruction logic using strings.Builder for consistency.
  • Updated the AST definition to reflect the new ARG instruction structure.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/parser/parser_test.go Updated test comparisons to validate the new key-value map.
pkg/parser/parser.go Modified parsing function to support multiple assignments.
pkg/ast/reconstruct_test.go Revised tests to reflect the changed format in reconstructed ARG.
pkg/ast/reconstruct.go Refactored ARG reconstruction using sorted keys and strings.Builder.
pkg/ast/ast.go Updated AST definition for ARG to use a key-value map and modified ToString.

coffeemakingtoaster and others added 3 commits June 25, 2025 14:50
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@coffeemakingtoaster coffeemakingtoaster merged commit fc03484 into main Jun 25, 2025
2 checks passed
@coffeemakingtoaster coffeemakingtoaster deleted the feat/1-multiple-assignment-support-for-arg branch July 21, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add multiple assignement support to arg

2 participants