Skip to content

Fix satp remove issue #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Race666 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix satp remove issue #10

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17298fd
Update bestpractices.ps1
Race666 Apr 22, 2022
e9c3c76
Update bestpractices.ps1
Race666 Apr 22, 2022
cef7e1b
Update bestpractices.ps1
Race666 Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions bestpractices.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,14 +402,35 @@ foreach ($esx in $hosts)
}
if ($issuecount -ge 1)
{
[bool]$RuleDeleted=$false
$satpArgs = $esxcli.storage.nmp.satp.rule.remove.createArgs()
$satpArgs.model = $rule.Model
$satpArgs.vendor = "PURE"
$satpArgs.satp = $rule.Name
$satpArgs.psp = $rule.DefaultPSP
$satpArgs.pspoption = $rule.PSPOptions
add-content $logfile "This rule is incorrect, deleting..."
$esxcli.storage.nmp.satp.rule.remove.invoke($satpArgs)
add-content $logfile "This rule is incorrect, trying to delete..."
try
{
$esxcli.storage.nmp.satp.rule.remove.invoke($satpArgs)
add-content $logfile "rule deleted successfully"
$RuleDeleted=$true
}
catch {
add-content $logfile "Deleting of rule failed maybe boot property is not set correctly"
}
if($RuleDeleted -ne $true)
{
add-content $logfile "This rule is incorrect, trying to delete with boot=true..."
$satpArgs.boot=$true
$esxcli.storage.nmp.satp.rule.remove.invoke($satpArgs)
add-content $logfile "rule deleted successfully"
$RuleDeleted=$true
}
if($RuleDeleted -ne $true)
{
add-content $logfile "rule delete failed"
}
add-content $logfile "*****NOTE: Deleted the rule.*****"
add-content $logfile "-----------------------------------------------"
}
Expand Down Expand Up @@ -545,4 +566,4 @@ foreach ($esx in $hosts)
}
}
disconnect-viserver -Server $vcenter -confirm:$false
add-content $logfile "Disconnected vCenter connection"
add-content $logfile "Disconnected vCenter connection"