Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(story): restore single-card AnimatedFeatureGrid story #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
fix(story): restore single-card AnimatedFeatureGrid story #463
Changes from all commits
0e8e5edd8821da8def0ee4015e78926f72586c55481fc66d2File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aria-expandedis applied to the wrong element/role.role="group"does not supportaria-expanded. Movearia-expandedto the actual interactive toggle element (the clickable card control).🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a semantic button for card toggles and functional state updates.
Interactive behavior on a
divrequires manual keyboard/a11y plumbing and is currently flagged by a11y lint. Use<button type="button">witharia-expanded, and switch toggles to functional updates.Suggested fix
📝 Committable suggestion
🧰 Tools
🪛 Biome (2.4.15)
[error] 63-63: The HTML element div is non-interactive. Do not use tabIndex.
(lint/a11y/noNoninteractiveTabindex)
🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.