refactor!: remove utils.script_path and replace with utils.module_dir#166
Merged
amirbilu merged 1 commit intocodota:masterfrom Mar 25, 2024
Merged
refactor!: remove utils.script_path and replace with utils.module_dir#166amirbilu merged 1 commit intocodota:masterfrom
amirbilu merged 1 commit intocodota:masterfrom
Conversation
This more clearly describes what it returns. script_path is replaced with script_dir which returns a value based on the currently running file note: module_dir relies on utils.lua's location, and will break if the file is moved
Closed
amirbilu
approved these changes
Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part 3 of #141
This more clearly describes what it returns.
script_path is replaced with script_dir which returns a value based on the currently running file
note: module_dir relies on utils.lua's location, and will break if the file is moved