Add esupgrade pre-commit hook #366
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 8 8
Lines 264 264
=======================================
Hits 258 258
Misses 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the esupgrade pre-commit hook to automatically modernize JavaScript code by replacing legacy global object references with their modern equivalents.
- Adds esupgrade hook configuration to
.pre-commit-config.yaml - Applies esupgrade transformations to existing JavaScript code, replacing
windowwithglobalThis - Updates console logging method from
console.logtoconsole.infoin test file
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.pre-commit-config.yaml |
Adds esupgrade pre-commit hook at version 2025.8.0 |
s3file/static/s3file/js/s3file.js |
Updates window.CustomEvent to globalThis.CustomEvent for better cross-environment compatibility |
tests/__tests__/s3file.test.js |
Updates window.SubmitEvent to globalThis.SubmitEvent and changes console.log to console.info |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
Included in #367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.