fix: add missing TimeFrame members to granularity_order#419
Merged
Conversation
The granularity_order dict in vector_backtest_service.py was missing SIX_HOUR, EIGHT_HOUR, THREE_DAY, THIRTY_MINUTE, and several other TimeFrame members, causing KeyError when strategies use these timeframes. Added all TimeFrame enum members with minute-based rank values. Added 6 unit tests covering the previously-crashing timeframes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #417 —
granularity_orderinvector_backtest_service.pywas missingSIX_HOUR,EIGHT_HOUR,THREE_DAY,THIRTY_MINUTE, and several otherTimeFrameenum members, causing aKeyErrorwhen strategies use these timeframes in vector backtests.Changes
vector_backtest_service.py: Added allTimeFrameenum members togranularity_orderwith minute-based rank valuestest_granularity_order.pycovering all previously-crashing timeframes and verifying correct orderingTesting
Closes #417