Feature aboutus #12
Open
Feature aboutus #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nurmerey
requested changes
Aug 13, 2021
Contributor
nurmerey
left a comment
nurmerey
left a comment
There was a problem hiding this comment.
Overall looks good @AayVer! I added a few clean-up requests. A few more things:
- Please add the About us page screenshot into the Pull Request description.
- Please add "Prettier" extension to your VSCode plugin, this should help keep the code formatting clean - https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode. To do formatting on save, here is handy dandy tutorial - https://www.robinwieruch.de/how-to-use-prettier-vscode. Once reformatted, make sure to push the changes to this branch 😸
| ]; | ||
| const BackgroundHead = { | ||
| backgroundImage: 'url('+img+')', | ||
|
|
| // <DSAHosts | ||
| // image="/static/media/ca_logo.048e32ba.png" title="Coding Allies" | ||
| // description={"ABOUT PAGE Main Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum."} | ||
| // /> |
Contributor
There was a problem hiding this comment.
Please remove commented-out lines L45-48. It looks like you have taken care of content above, so need to keep them here 😃
| // <Box> | ||
| // <h5>About</h5> | ||
| // <p>ABOUT PAGE Main Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p> | ||
| // </Box> |
Contributor
There was a problem hiding this comment.
nit: same here, please remove commented out code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes in about us page