Skip to content

Update Wfs to use unwrap Antimeridian functionality 2.29.x#6957

Open
nickchooleidos wants to merge 1 commit intocodice:2.29.xfrom
nickchooleidos:fix-antimeridian-support-wfs-2.29.x
Open

Update Wfs to use unwrap Antimeridian functionality 2.29.x#6957
nickchooleidos wants to merge 1 commit intocodice:2.29.xfrom
nickchooleidos:fix-antimeridian-support-wfs-2.29.x

Conversation

@nickchooleidos
Copy link

What does this PR do?

The cause was that when a polygon crosses the antimeridian (180°/-180° longitude line), the system was treating the coordinates as a continuous range rather than recognizing the wrap-around at the antimeridian. For example, with coordinates [[174°,-4°], [-138°,9°]], the system interpreted this as covering all longitudes from -138° to 174° (spanning 312°), instead of the intended area that wraps around the antimeridian (spanning 48°).

This resulted in queries returning results from the entire middle section between the coordinates, rather than just the intended area that crosses the antimeridian boundary. The solution splits polygons that cross the antimeridian into two separate polygons - one covering -180° to the western longitude, and another from the eastern longitude to 180°, ensuring correct spatial queries across the antimeridian.

There's an existing method that solves this issue but it wasn't invoked anywhere. This PR aims to invoke that method

How should this be tested?

Maven compile this package. Then drop the jar file in a DDF box. Perform location searches and also test in Search Areas. Verify if there are still results returning outside of the drawing

Any background context you want to provide?

What are the relevant tickets?

Screenshots

image image

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2026

CLA assistant check
All committers have signed the CLA.

@nickchooleidos nickchooleidos force-pushed the fix-antimeridian-support-wfs-2.29.x branch 2 times, most recently from 4e0c118 to fbcaaf0 Compare February 5, 2026 05:33
@derekwilhelm
Copy link
Contributor

build now

@cxddfbot
Copy link

cxddfbot commented Feb 5, 2026

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

cxddfbot commented Feb 5, 2026

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

@derekwilhelm
Copy link
Contributor

build now

@cxddfbot
Copy link

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@nickchooleidos nickchooleidos force-pushed the fix-antimeridian-support-wfs-2.29.x branch from fbcaaf0 to cf4b1b9 Compare February 11, 2026 23:43
@derekwilhelm
Copy link
Contributor

build now

@cxddfbot
Copy link

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@derekwilhelm
Copy link
Contributor

build now

@cxddfbot
Copy link

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants