Allow adding a large product #1077
Conversation
|
@alexabird can you review this please? |
| ECLIPSE_MULTIPART_CONFIG, | ||
| new MultipartConfigElement(System.getProperty(JAVA_IO_TMPDIR))); | ||
| LOGGER.trace("POST Path: {}", CATALOG_PATH); | ||
| try { |
There was a problem hiding this comment.
I'd move this out into it's own private function that returns a response object
| new ByteArrayInputStream(req.bodyAsBytes())); | ||
| res.status(HttpStatus.SC_NOT_FOUND); | ||
| return res; | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
I'd catch more specific exceptions here, CatalogServiceExceptions get caught and handled by the addDocument() calls. I think we only need to catch the IOExceptions and ServletExceptions thrown by the MultipartBodyFactory.create() method
| private String mapHome = ""; | ||
|
|
||
| private int maximumUploadSize = 1_048_576; | ||
| private long maximumUploadSize = 1_048_576L; |
There was a problem hiding this comment.
I'd put a comment here like the other variables you've added
| part.delete(); | ||
| LOGGER.debug("Temporary file '{}' deleted successfully", part.getName()); | ||
| } | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Just catch an IOException here, it's the only exception part.delete() throws
ardasmax
left a comment
ardasmax
left a comment
There was a problem hiding this comment.
Thanks Liz, looking through the aus one now
| CATALOG_PATH, | ||
| (req, res) -> { | ||
| if (req.contentType().startsWith("multipart/")) { | ||
| req.attribute( |
There was a problem hiding this comment.
Was this intentionally not included in the handleCatalogPost?
There was a problem hiding this comment.
this bit is in AutoCloseableMultipartBodyFactory now
|
build now |
|
Internal build has been started, your results will be available at build completion. |
|
Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI. |
Suspected Failure(s):
|
| private static final String BYTES = "bytes"; | ||
|
|
||
| private static final String CATALOG_PATH = "/catalog/"; | ||
| private static final String CATALOG_ID_PATH = "/catalog/:id"; |
There was a problem hiding this comment.
You could do
private static final String CATALOG_ID_PATH = CATALOG_PATH + ":id";
# Conflicts: # ui-backend/catalog-ui-search/src/main/java/org/codice/ddf/catalog/ui/catalog/CatalogApplication.java
|
build now |
|
Internal build has been started, your results will be available at build completion. |
|
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
# Conflicts: # pom.xml
|
@ardasmax @alexabird The refactoring of AutoCloseableMultipartBody/Factory into multipart-utils module is done. Can you please have a quick review in regards to that? Thanks |
|
build now |
|
Internal build has been started, your results will be available at build completion. |
|
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
5 participants
This PR allows a large file upload (separate server settings might need to be updated to allow bigger files and longer time out).