Skip to content

Upgrade netty to resolve CVEs#1013

Open
zkirksey wants to merge 1 commit into
masterfrom
upgrade-netty
Open

Upgrade netty to resolve CVEs#1013
zkirksey wants to merge 1 commit into
masterfrom
upgrade-netty

Conversation

@zkirksey
Copy link
Copy Markdown
Contributor

What does this PR do?

Upgrade netty to 4.1.133.Final to resolve CVEs

Who is reviewing it?

(please choose AT LEAST two reviewers that need to approve the PR before it can get merged; if a component team is listed, at least one of its members needs to approve)

Choose 2 committers to review/merge the PR.

(please choose ONLY two committers from below, delete the rest)

@andrewkfiedler
@bdeining
@beyelerb
@brendan-hofmann
@brjeter
@clockard
@coyotesqrl
@figliold
@jaymcnallie
@jlcsmith
@kcwire
@lessarderic
@michaelmenousek
@millerw8
@mrmateo
@pklinef
@ricklarsen - Documentation
@rzwiefel
@shaundmorris
@stustison
@tbatie
@vinamartin

How should this be tested?

Any background context you want to provide?

What are the relevant tickets?

CAL-xxx

Screenshots (if appropriate)

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Copy link
Copy Markdown
Member

@jaymcnallie jaymcnallie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhere along the way netty-all changed from a fat bundle to an aggregator. It builds fine if you include netty-all since the build will resolve all the transitive dependencies. However, loading just netty-all into the OSGi container doesn't actually bring the submodules onto the class path at runtime. Update to explicitly depend on the submodules required. The sdk-app features file will need to be updated too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants