Remove quantity field from Item._encode() #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'quantity' field does not exist in the ListItem protobuf schema (see lib/definitions.json). Including it in _encode() causes protobuf encoding errors when calling methods like removeItem() that need to encode the item. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
quantityfield does not exist in theListItemprotobuf schema (seelib/definitions.json). Including it in_encode()causes protobuf encoding errors when calling methods likeremoveItem()that need to encode the item.Problem
When trying to remove an item from a list using
list.removeItem(item), the following error occurs:This happens because
_encode()tries to includequantity: this._quantitybut the protobuf schema forListItemdoesn't have aquantityfield.Solution
Remove the
quantityfield from the_encode()method since it's not part of the protobuf schema.🤖 Generated with Claude Code