Skip to content

SANDBOX-1769 | feature: type for "disabled integrations" in the config#502

Open
MikelAlejoBR wants to merge 1 commit intocodeready-toolchain:masterfrom
MikelAlejoBR:SANDBOX-1769-feature-enable-integrations-ui-api
Open

SANDBOX-1769 | feature: type for "disabled integrations" in the config#502
MikelAlejoBR wants to merge 1 commit intocodeready-toolchain:masterfrom
MikelAlejoBR:SANDBOX-1769-feature-enable-integrations-ui-api

Conversation

@MikelAlejoBR
Copy link
Copy Markdown

@MikelAlejoBR MikelAlejoBR commented Apr 10, 2026

Description

We want to be able to control the integrations that are displayed in the UI via the ToolchainConfig, and in order to do that we need to have a field that controls which integrations are enbaled and which are not.

Related PRs

Jira ticket

[SANDBOX-1769]

Checks

  1. Did you run make generate target? yes/no

Yes.

  1. Did make generate change anything in other projects (host-operator, member-operator)? yes/no

Yes.

  1. In case of new CRD, did you the following? yes/no

It is not a new CRD, but rather a change in an existing one.

  1. In case other projects are changed, please provides PR links.

Will do as soon as I open them

Summary by CodeRabbit

  • New Features
    • Added an optional configuration to hide/disable specific integrations in the UI; when unset or empty, all integrations remain enabled.
  • Documentation
    • Updated API reference and schema to document the new integration-visibility configuration and its behavior.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

Walkthrough

Added a new optional disabledIntegrations string-array field to RegistrationServiceConfig, documented its UI behavior (nil/empty = all enabled; listed = hidden/disabled), and updated type definitions, deepcopy logic, and the generated OpenAPI schema.

Changes

Cohort / File(s) Summary
Type Definition & Documentation
api/v1alpha1/toolchainconfig_types.go, api/v1alpha1/docs/apiref.adoc
Added DisabledIntegrations []string (json:"disabledIntegrations,omitempty", +optional, +listType=set) to RegistrationServiceConfig and documented its semantics for hiding/disabling integrations in the UI.
Generated Helpers & Schema
api/v1alpha1/zz_generated.deepcopy.go, api/v1alpha1/zz_generated.openapi.go
Updated deepcopy to deep-copy the new slice field and extended the OpenAPI schema to include disabledIntegrations as an array of strings with x-kubernetes-list-type: set and descriptive text.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description covers the main objective, includes related PRs, and addresses all applicable checklist items with clear answers, though some PR links for dependent projects are marked as pending.
Title check ✅ Passed The title mentions 'disabled integrations' but the PR objectives and description state the feature is about controlling which integrations are 'enabled' or 'disabled' for conditional UI display. The title accurately reflects the main change—adding a type/field for disabled integrations in the config.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

We want to be able to control the integrations that are displayed in the
UI via the ToolchainConfig, and in order to do that we need to have a
field that controls which integrations are disabled.

SANDBOX-1769
@MikelAlejoBR MikelAlejoBR force-pushed the SANDBOX-1769-feature-enable-integrations-ui-api branch from 621221a to bb2c83a Compare April 14, 2026 19:55
@sonarqubecloud
Copy link
Copy Markdown

@MikelAlejoBR MikelAlejoBR changed the title SANDBOX-1769 | feature: type for "enabled integrations" in the config SANDBOX-1769 | feature: type for "disabled integrations" in the config Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants