Skip to content

add cluster owner label for the nstemplateset resource #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rsoaresd wants to merge 8 commits into from
Closed

add cluster owner label for the nstemplateset resource #489

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6347957
fix
rsoaresd May 6, 2025
8565e07
Merge branch 'codeready-toolchain:master' into master
rsoaresd Jul 27, 2025
beefdef
Merge branch 'codeready-toolchain:master' into master
rsoaresd Sep 2, 2025
8cf8ac3
Merge branch 'codeready-toolchain:master' into master
rsoaresd Sep 4, 2025
312ce75
Merge branch 'codeready-toolchain:master' into master
rsoaresd Sep 8, 2025
c909e99
Merge branch 'codeready-toolchain:master' into master
rsoaresd Sep 10, 2025
bb90fce
Merge branch 'codeready-toolchain:master' into master
rsoaresd Oct 8, 2025
f990a90
add ClusterOwnerLabelKey
rsoaresd Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions api/v1alpha1/nstemplateset_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,14 @@ import (
)

const (
OwnerLabelKey = LabelKeyPrefix + "owner"
SpaceLabelKey = LabelKeyPrefix + "space"
TypeLabelKey = LabelKeyPrefix + "type"
TemplateRefLabelKey = LabelKeyPrefix + "templateref"
TierLabelKey = LabelKeyPrefix + "tier"
ProviderLabelKey = LabelKeyPrefix + "provider"
ProviderLabelValue = "codeready-toolchain"
OwnerLabelKey = LabelKeyPrefix + "owner"
SpaceLabelKey = LabelKeyPrefix + "space"
TypeLabelKey = LabelKeyPrefix + "type"
TemplateRefLabelKey = LabelKeyPrefix + "templateref"
TierLabelKey = LabelKeyPrefix + "tier"
ProviderLabelKey = LabelKeyPrefix + "provider"
ProviderLabelValue = "codeready-toolchain"
ClusterOwnerLabelKey = LabelKeyPrefix + "cluster-owner"
Copy link
Contributor

@metlos metlos Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This label is needed only in the member operator for distinguishing between 2 member operators running in a single cluster. As far as I understood the problem, this label isn't really needed if the members are in different clusters.

So "cluster-owner" seems a bit confusing to me. What about something like "managing-member"?


LastAppliedSpaceRolesAnnotationKey = LabelKeyPrefix + "last-applied-space-roles"
)
Expand Down
Loading