🤖 perf: renderer hot paths + build optimizations #1357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibetitsmike
force-pushed
the
performance-5f01
branch
from
785e8bc to
84a5ac8
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ibetitsmike
force-pushed
the
performance-5f01
branch
from
84a5ac8 to
10416f5
Compare
Build/packaging (C1-C3): - Gate sourcemaps off in production (opt-in via MUX_RENDERER_SOURCEMAPS=1) - Move renderer output to dist/renderer/ with emptyOutDir:true for clean builds - Split mermaid (~2.3MB) and ghostty-web (~634KB) into on-demand chunks Renderer hot paths (B1-B2, B5): - Precompute bash output group boundaries in O(n) instead of O(n²) - Defer Mermaid rendering until visible (IntersectionObserver) + SVG cache - Dynamic import for mermaid and ghostty-web (lazy load large deps) - Adaptive polling in useResumeManager (1s when active, 5s when idle) Validation: - make typecheck passes - Existing tests pass - Build produces correct dist/ structure with chunked deps
ibetitsmike
force-pushed
the
performance-5f01
branch
from
10416f5 to
c79da82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements performance optimizations from the Electron guide-based analysis. Focus areas:
Build/Packaging (C1-C3)
MUX_RENDERER_SOURCEMAPS=1)dist/renderer/withemptyOutDir: trueto prevent stale asset accumulationRenderer Hot Paths (B1-B2, B5)
useResumeManagernow uses 1s interval when workspaces need attention, 5s when idleTesting
make typecheck✓Not Included (future follow-ups)
@tanstack/react-virtual+ more complex changes)Generated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high