fix: handle nil actor from context in trace attributes #136
+100
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
pawbana
approved these changes
Jan 22, 2026
Contributor
pawbana
left a comment
pawbana
left a comment
There was a problem hiding this comment.
LGTM, it would be nice to have a simple test that would test nil actor in context scenario.
ssncferreira
force-pushed
the
ssncferreira/fix-actor-nil
branch
from
b99f59b to
7bd40c9
Compare
ssncferreira
force-pushed
the
ssncferreira/fix-actor-nil
branch
from
9182ea4 to
6a9968e
Compare
Contributor
Author
Good point, addressed in 6a9968e |
Contributor
Author
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a nil pointer dereference when extracting Actor ID for trace attributes.
Discovered while testing the Copilot provider implementation (implemented upstack #137), where requests may not always have an actor set in the context.
Changes
Adds
ActorIDFromContexthelper that safely returns an empty string if no actor is present, and updates the interceptors to use it.