Skip to content

fix: add queue position display to template creation #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cdr-robot wants to merge 1 commit into from
Closed

fix: add queue position display to template creation #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions site/src/modules/provisioners/ProvisionerStatusAlert.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,23 @@ interface ProvisionerStatusAlertProps {
availableProvisioners: number | undefined;
tags: Record<string, string>;
variant?: AlertVariant;
queuePosition?: number;
queueSize?: number;
}

export const ProvisionerStatusAlert: FC<ProvisionerStatusAlertProps> = ({
matchingProvisioners,
availableProvisioners,
tags,
variant = AlertVariant.Standalone,
queuePosition,
queueSize,
}) => {
let title: string;
let detail: string;
let severity: AlertColor;
const showQueuePosition = queuePosition !== undefined && queueSize !== undefined && queueSize > 0;

switch (true) {
case matchingProvisioners === 0:
title = "Build pending provisioner deployment";
Expand All @@ -33,8 +39,9 @@ export const ProvisionerStatusAlert: FC<ProvisionerStatusAlertProps> = ({
break;
default:
title = "Build enqueued";
detail =
"Your build has been enqueued and will begin once a provisioner becomes available to process it.";
detail = showQueuePosition
? `Your build has been enqueued and is waiting in a queue. Position in queue: ${queuePosition}/${queueSize}`
: "Your build has been enqueued and will begin once a provisioner becomes available to process it.";
severity = "info";
}

Expand Down
4 changes: 3 additions & 1 deletion site/src/pages/CreateTemplatePage/BuildLogsDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ export const BuildLogsDrawer: FC<BuildLogsDrawerProps> = ({
availableProvisioners={availableProvisioners}
tags={templateVersion?.job.tags ?? {}}
variant={AlertVariant.Inline}
queuePosition={templateVersion?.job.queue_position}
queueSize={templateVersion?.job.queue_size}
/>
<Loader />
</>
Expand Down Expand Up @@ -196,4 +198,4 @@ const bannerStyles = {
button: {
marginTop: 16,
},
} satisfies Record<string, Interpolation<Theme>>;
} satisfies Record<string, Interpolation<Theme>>;
Loading