Draft
Conversation
While jest can run a package and its tests without needing a full build step, it will use the last-built version of the other packages for its dependencies, so we're not actually guaranteed to be testing the latest state unless we build all of a package's local dependencies before we start testing it. The `test:watch` scripts have been removed, as a watch mode that tests without building the dependencies is not reliable. I don't think any local packages are getting injected, but I added `syncInjectedDepsAfterScripts` to `pnpm-workspace.yaml` to be safe. Since we're running tests in parallel, individual tests run slower, so I had to increase some timeouts.
Replaces `codemod-dev` shell script with a new `cli` pnpm script in the top-level package
ItsHarper
force-pushed
the
chore/update-typescript
branch
from
8360cb1 to
094f799
Compare
This was referenced Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Step 3 for #928. View isolated diff and CI results here: ItsHarper#6
At time of writing, the isolated diff has
+157, -143lines added/removed, almost all of which are in the lockfile. As always, I recommend verifying that I did not make any hand-edits.This change is ready-to-go, but I'm marking it as a draft until #929 has been merged, as it is relatively difficult to review in this context until that happens.
Description
Updates Typescript to the latest version (
5.9.2).Only minimal changes were required to fix the build after the typescript update.
Unfortunately,
@types/nodereleases target specific typescript versions as much as they do node versions, so I updated all the way to the latest version instead of picking one that matches the minimum target node version.Even just this version bump without any configuration changes makes a repeat build with no changes made take just 1.8 seconds on my machine, compared to 2.4 seconds for #930.