Conversation
Maintenance LTS, Active LTS, and Current
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GitHub Actions CI matrix to test newer Node.js versions aligning with maintenance LTS, active LTS, and current releases.
- Replace tests on Node 16.x and 18.x with 20.x, 22.x, and 24.x
- Ensure CI covers the intended lifecycle stages of Node.js
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:11
- The updated Node.js matrix omits the maintenance LTS version (18.x) mentioned in the description and includes 22.x, which is not an LTS. To match the goal of testing maintenance LTS, active LTS, and current, consider using [18.x, 20.x, 24.x] instead.
node-version: [20.x, 22.x, 24.x]
|
To elaborate on what I said about this PR in #927, CI is failing because of a new deprecation warning added to node 24 about the We could hack the test to disable checking stderr, but it would be much better just to not use the problematic URL parser. We're currently using Like I said in #927, I did try to switch to native |
Maintenance LTS, Active LTS, and Current.