Skip to content

add support for 'mul' labels from Wikidata #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VDK wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add support for 'mul' labels from Wikidata #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/addLabel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export default function addLabel(entity: Entity, languageCode: LangCode) {
const { labels } = entity;
if (!labels) return;

let labelObject = labels[languageCode];
let labelObject = labels.mul || labels[languageCode];
if (!labelObject)
for (const defaultLangCode of DEFAULT_LANGS_CODES) {
const defaultLangLabel = labels[defaultLangCode];
Expand Down
2 changes: 1 addition & 1 deletion src/treeHelpers/getEntities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export default async function getEntities(
return entities;
}

const languages = DEFAULT_LANGS_CODES;
const languages = ["mul"].concat(DEFAULT_LANGS_CODES);

//avoid duplicate language, but it won't break anyway
if (!languages.includes(languageCode)) languages.push(languageCode);
Expand Down
2 changes: 1 addition & 1 deletion src/wikibase/getWikibaseEntitiesLabel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default async function getWikibaseEntitiesLabel(

const allentities = await getWikibaseEntities({
ids,
languages: [languageCode].concat(DEFAULT_LANGS_CODES),
languages: ["mul", languageCode].concat(DEFAULT_LANGS_CODES),
props: ["labels"],
dataSource,
});
Expand Down