Skip to content

Conversation

@neznaika0
Copy link
Contributor

Description
Fixes #9711
It is better to merge the develop branch for the review.

  • Removed the check for a valid ID as method. It's too hard to choose a direction. Returned the deleted checks
  • Added dots in comments, some formatting
  • Updated PHPDoc in phpstan style
  • Inherited comments have been removed
  • Updated phpstan-baseline

I have re-examined the proposed ID check method. I realized that it is less useful for BaseModel. The method is useful in the Model. As long as you consider the check to be breaking changes, let everything stay as it was.

There is a note for row_array - in the case of casting, the value can be mixed. Contain any type inside, which is converted to scalars. Find the error in utils/phpstan-baseline/argument.type.neon DataConverterModelTest.php

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update Deptrac.

@michalsn michalsn added refactor Pull requests that refactor code 4.7 labels Dec 11, 2025
@neznaika0 neznaika0 force-pushed the refactor/model-types branch from de4b6e8 to 9b5e64b Compare December 11, 2025 20:03
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me.

@michalsn michalsn merged commit c9d3dcd into codeigniter4:4.7 Dec 13, 2025
50 checks passed
@michalsn
Copy link
Member

Thank you @neznaika0

@neznaika0 neznaika0 deleted the refactor/model-types branch December 15, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.7 refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants