Rpatel/safe import #1220
Merged
Rpatel/safe import #1220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codegen-team
approved these changes
Aug 19, 2025
![codegen-sh[bot]](https://avatars.githubusercontent.com/in/321279?s=60&v=4){kind=small}
|
|
||
| from codegen.cli.utils.org import resolve_org_id | ||
|
|
||
| # Add the codegen CLI to the path so we can import from it |
Contributor
There was a problem hiding this comment.
Logic error: resolve_org_id can be undefined if import fails
If the import inside the try block raises ImportError, only create_claude_session is set to None. resolve_org_id remains undefined and later usage (if org_id is None and resolve_org_id:) will raise a NameError, causing the hook to fail at runtime.
Suggested change
| # Add the codegen CLI to the path so we can import from it | |
| try: | |
| from codegen.cli.commands.claude.claude_session_api import create_claude_session | |
| from codegen.cli.utils.org import resolve_org_id | |
| except ImportError: | |
| create_claude_session = None | |
| resolve_org_id = None |
Contributor
|
Found 0 critical and 1 important issues. Please review my inline comments above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Content
Testing
Please check the following before marking your PR as ready for review