-
Notifications
You must be signed in to change notification settings - Fork 14
Add docker flow #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add docker flow #262
Changes from all commits
17ecda2
507bc05
dd84256
1e9a691
02057a2
168d6c5
6704eeb
22d3457
53d3124
fd3632b
8602786
e912e0a
e720697
9600bf0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,28 @@ | ||||||||||
| # Google Cloud configuration | ||||||||||
| GOOGLE_CLOUD_PROJECT=tenantfirstaid | ||||||||||
| GOOGLE_CLOUD_LOCATION=global | ||||||||||
| VERTEX_AI_DATASTORE=<YOUR_DATASTORE_ID> | ||||||||||
|
|
||||||||||
| # Path to Google credentials on your HOST machine | ||||||||||
| # Default location after 'gcloud auth application-default login' | ||||||||||
| GOOGLE_APPLICATION_CREDENTIALS=/home/<USERNAME>/.config/gcloud/application_default_credentials.json | ||||||||||
|
|
||||||||||
| # Model configuration | ||||||||||
| MODEL_NAME=gemini-2.5-pro | ||||||||||
| SHOW_MODEL_THINKING=true | ||||||||||
| LOG_LEVEL=DEBUG | ||||||||||
|
|
||||||||||
| # Flask configuration | ||||||||||
| FLASK_SECRET_KEY=dev-secret-key-unsafe | ||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The "unsafe" suffix is easy to miss. Add an explicit generation command and make the warning harder to skip:
Suggested change
|
||||||||||
|
|
||||||||||
| # LangSmith (optional) | ||||||||||
| LANGSMITH_API_KEY=<YOUR_LANGSMITH_KEY> | ||||||||||
| LANGSMITH_TRACING=true | ||||||||||
| LANGCHAIN_TRACING_V2=true | ||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If
Suggested change
|
||||||||||
|
|
||||||||||
| # SMTP (optional for local dev) | ||||||||||
| #MAIL_SERVER=smtp.gmail.com | ||||||||||
| #MAIL_PORT=587 | ||||||||||
| #SENDER_EMAIL=your_email@gmail.com | ||||||||||
| #APP_PASSWORD=your_app_password | ||||||||||
| #RECIPIENT_EMAIL=recipient@example.com | ||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| __pycache__/ | ||
| *.pyc | ||
| *.pyo | ||
| *.pyd | ||
| .Python | ||
| *.so | ||
| *.egg | ||
| *.egg-info/ | ||
| dist/ | ||
| build/ | ||
| .venv/ | ||
| venv/ | ||
| .env | ||
| .env.* | ||
| !.env.example | ||
| *.log | ||
| .pytest_cache/ | ||
| .mypy_cache/ | ||
| .ruff_cache/ | ||
| .coverage | ||
| htmlcov/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security: Unsafe default for production
The example includes
FLASK_SECRET_KEY=dev-secret-key-unsafewhich could accidentally be used in production.Recommendation:
Consider adding a startup check in the Flask app that errors if the secret key matches known insecure defaults.