Skip to content

Conversation

@mkou-i
Copy link

@mkou-i mkou-i commented Jun 24, 2025

For #361:

  • Customer suggested command/control + A + R
  • VSCODE doesn't accept modifer + multiple keys. Tested locally, and it showed as 'unknown'. Documentation / editor allows for key chords. Settled on CTRL + a

For codefori#361

VSCODE doesn't accept modifer + multiple keys. Went with CTRL+a
@worksofliam worksofliam changed the title Added default run all keybind [#361](https://github.com/codefori/vscode-db2i/issues/361) Added default run all keybind #361 Aug 23, 2025
@worksofliam worksofliam added this to the Fix day milestone Aug 23, 2025
Comment on lines 209 to 210
"key": "ctrl+a",
"mac": "cmd+a",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We absolutely cannot use Control/Command + A as the keybinding. This is 'select all' in most everything.

You can use the combo of Control/Command + A + R as originally suggested. See how we do it elsewhere in this file.

@worksofliam worksofliam removed this from the Fix day August milestone Aug 26, 2025
@mkou-i
Copy link
Author

mkou-i commented Aug 26, 2025

Liam, Control/Command + A + R would be invalid. There are limitations to how many 'keys' can be used in one sequence.

Changed it to a key chord -> "ctrl+r a". This would stray a bit away from the other key bindings.

Copy link
Member

@SanjulaGanepola SanjulaGanepola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkou-i The problem with ctrl+r a / cmd+r a is that when the user first hits ctrl+r to start the key cord, it will prevent the standard ctrl+r shortcut from running which is most commonly used to run a given SQL statement. You can even see in the status bar it will just wait:

image

I suggest switching over to ctrl+a ctrl+r / cmd+a cmd+r which just means the user needs to press all 3 keys at the same time (which I assume is what you were looking for).

@SanjulaGanepola
Copy link
Member

@mkou-i Ok so turns out that won't work either as hitting ctrl+a will also end up waiting for the next key. How about ctrl+alt+a / cmd+alt+a

@SanjulaGanepola SanjulaGanepola mentioned this pull request Jan 16, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants