Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… and adjust follower fetching logic
jicruz96
requested review from
Mephistic,
alexjball,
kiminkim724,
mertbagt,
mvictor55,
nesanders,
sashamaryl and
timblais
as code owners
Mephistic
reviewed
Oct 14, 2025
Collaborator
Mephistic
left a comment
Mephistic
left a comment
There was a problem hiding this comment.
💯 Love this, thanks for jumping on this cleanup! Only blocker I see on merging this is fixing the broken translation keys.
| <OutlineButton | ||
| className="col-3 ms-auto" | ||
| onClick={onCancel} | ||
| label={t("confirmation.no")} |
Collaborator
There was a problem hiding this comment.
nit: The translation keys for confirmation are in the editProfile json file, not the common file - so these lookups won't work. We either need to move these keys to common or include editProfile as a translation root. Given that we use the Follow buttons outside of the edit profile page (even if we don't have confirmation modals enabled in those places at the moment), my vote would be for moving the keys to common.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PaginatedItemsCardfor generic paginated lists with loading/error statesFollowUserCardfor rendering user profiles with follow buttonsFollowUserButtonandFollowBillButtonfor consistent follow/unfollow button behavior with optional confirmation modalsWalkthrough
PaginatedItemsCardcomponent (components/shared/PaginatedItemsCard.tsx)PaginatedItemsCardresponsible for pagination state, loading/error messaging, and rendering arbitrary item cards.FollowUserCardcomponents (components/EditProfilePage/FollowUserCard.tsx)FollowingTabandFollowersTab.components/EditProfilePage/FollowingTab.tsx)PaginatedItemsCardto render bill and profiles.FollowingTabComponents/UnfollowModal(both deleted).components/EditProfilePage/FollowersTab.tsx)PaginatedItemsCard.components/shared/FollowButton.tsx)BaseFollowButton.BaseFollowButtonso screens can opt-in to confirmation easily.FollowUserButton/FollowBillButton.components/shared/FollowingQueries.tsx)PolicyActions+TestimonyDetailPageswitch to the new helpers.