perf: use shallow copy for args/test_cfg in worktree mode#2129
Merged
KRRT7 merged 2 commits intocf-perf-improvementsfrom May 7, 2026
Merged
perf: use shallow copy for args/test_cfg in worktree mode#2129KRRT7 merged 2 commits intocf-perf-improvementsfrom
KRRT7 merged 2 commits intocf-perf-improvementsfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
copy.deepcopy()withcopy.copy()inmirror_paths_for_worktree_mode().Part of #2132 — targeted E2E pipeline performance improvements.
Problem
mirror_paths_for_worktree_mode()deep-copiesargs(argparse.Namespace) andtest_cfg(TestConfig). Deep copy recursively traverses every attribute — expensive for objects with many fields. But both objects contain only immutable types (Path, str, bool) and all fields are reassigned as new objects after copying.Solution
copy.copy()— creates a new object with shared references to the same immutable values. Safe because every field is subsequently overwritten with a new Path/str, so the original is never mutated through the copy.Changes
codeflash/optimization/optimizer.py:copy.deepcopy→copy.copy(2 lines)tests/test_worktree.py: 3 new tests verifying copy independenceTest plan
uv run pytest tests/test_worktree.py -v— all 4 tests pass