Skip to content

⚡️ Speed up function _is_test_file_by_pattern by 122% in PR #1759 (merge/misc-fixes-into-omni-java) #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codeflash-ai wants to merge 1 commit into from
Closed

⚡️ Speed up function _is_test_file_by_pattern by 122% in PR #1759 (merge/misc-fixes-into-omni-java) #1761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions codeflash/discovery/functions_to_optimize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@

from rich.text import Text

_TEST_NAME_PATTERNS = (".test.", ".spec.", "_test.", "_spec.")

_TEST_DIR_NAMES = frozenset(("test", "tests", "__tests__"))


@dataclass(frozen=True)
class FunctionProperties:
Expand Down Expand Up @@ -959,12 +963,13 @@ def _is_test_file_by_pattern(file_path: Path) -> bool:
name = file_path.name.lower()
if name.startswith("test_") or name == "conftest.py":
return True
test_name_patterns = (".test.", ".spec.", "_test.", "_spec.")
if any(p in name for p in test_name_patterns):
return True
path_str = str(file_path).lower()
test_dir_patterns = (os.sep + "test" + os.sep, os.sep + "tests" + os.sep, os.sep + "__tests__" + os.sep)
return any(p in path_str for p in test_dir_patterns)
for p in _TEST_NAME_PATTERNS:
if p in name:
return True
for part in file_path.parts[:-1]:
if part.lower() in _TEST_DIR_NAMES:
return True
return False


def _is_test_file_by_pattern(file_path: Path) -> bool:
Expand All @@ -976,12 +981,13 @@ def _is_test_file_by_pattern(file_path: Path) -> bool:
name = file_path.name.lower()
if name.startswith("test_") or name == "conftest.py":
return True
test_name_patterns = (".test.", ".spec.", "_test.", "_spec.")
if any(p in name for p in test_name_patterns):
return True
path_str = str(file_path).lower()
test_dir_patterns = (os.sep + "test" + os.sep, os.sep + "tests" + os.sep, os.sep + "__tests__" + os.sep)
return any(p in path_str for p in test_dir_patterns)
for p in _TEST_NAME_PATTERNS:
if p in name:
return True
for part in file_path.parts[:-1]:
if part.lower() in _TEST_DIR_NAMES:
return True
return False


def filter_files_optimized(file_path: Path, tests_root: Path, ignore_paths: list[Path], module_root: Path) -> bool:
Expand Down
Loading