fix: resolve Windows path case sensitivity in optimize changed code #1027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix git diff command for uncommitted changes (use "HEAD" instead of None, "HEAD") - Normalize paths using os.path.normcase() for case-insensitive comparison on Windows - Fixes issue where functions in git diff were not detected on Windows due to drive letter case mismatch
KRRT7
previously approved these changes
Jan 8, 2026
mohammedahmed18
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Windows path case sensitivity in "Optimize Changed Code" feature
Problem
On Windows, the "Optimize Changed Code" feature didn't detect functions in git diffs when the drive letter case differed (e.g.,
d:\code\...vsD:\code\...). Functions were filtered out as "outside module root" due to case-sensitive path comparisons.Solution
git.diff(None, "HEAD")togit.diff("HEAD")for uncommitted changesos.path.normcase()for case-insensitive comparisons on WindowsImpact