New feature significative event counter#43
New feature significative event counter#43Narfss wants to merge 1 commit intocodechimp-org:masterfrom
Conversation
There was a problem hiding this comment.
Replacing methods with the additional parameters will break existing implementations that use this particular calling method. It would be better to implement your own additional overloaded methods though I'm worried about telescoping this too far and getting a very messy implementation (more than it is today)
Commenting on just this one but there are further breaking overloads.
There was a problem hiding this comment.
I see it
At this point, the better choice is change all to pattern builder.
There was a problem hiding this comment.
Agreed, it would break existing compatibility but with yours and other feature requests it makes sense.
Unfortunately I don't have time to do this immediately and so will not only be maintaining current features for now but will start a new branch for a V2 in future.
2 participants
Prompting can be showed after some user significant interaction.
New counter SIGNIFICANT_EVENT and parameter in constructor.
Function userDidSignificantEvent increase the events counter and show rate promp.