fix(#5166): Render OUT_OF_SERVICE health status the same as DOWN#5175
Open
cdprete wants to merge 1 commit intocodecentric:masterfrom
Open
fix(#5166): Render OUT_OF_SERVICE health status the same as DOWN#5175cdprete wants to merge 1 commit intocodecentric:masterfrom
cdprete wants to merge 1 commit intocodecentric:masterfrom
Conversation
cdprete
force-pushed
the
master
branch
2 times, most recently
from
4970c56 to
1c017a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5166.
If I saw correctly, the Wallboard is already defaulting
OUT_OF_SERVICEtoDOWNand SbaStatus is also already using the red color and a proper icon.Therefore, unless I missed something, that one should be the only place where such a color setting was missing.