Add missing factory and helper methods for OUT_OF_SERVICE and RESTRICTED status #5012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TED status Adds convenience methods to StatusInfo for OUT_OF_SERVICE and RESTRICTED statuses to match the existing pattern used by UP, DOWN, and OFFLINE: - ofOutOfService() and ofRestricted() factory methods without details - ofOutOfService(Map) and ofRestricted(Map) factory methods with details - isOutOfService() and isRestricted() boolean helper methods This completes the API consistency across all status types defined in StatusInfo and makes the class easier to use. Tests added to verify the new factory methods and helper methods work correctly and follow the same pattern as existing status types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with
StatusInfo, I noticed thatOUT_OF_SERVICEandRESTRICTEDstatus types don't have the same convenience methods as other statuses likeUP,DOWN, andOFFLINE.This PR adds the missing methods to complete the API:
Factory methods:
ofOutOfService()/ofRestricted()- convenience methods without detailsofOutOfService(Map<String, Object> details)/ofRestricted(Map<String, Object> details)- methods with detailsHelper methods:
isOutOfService()/isRestricted()- boolean checkersThis makes the API more consistent and easier to use. All tests pass.