Bugfixes, removed 2 compiler warnings and code cleanup#17
Open
pmara84 wants to merge 1 commit intocodebots-ltd:masterfrom
Open
Bugfixes, removed 2 compiler warnings and code cleanup#17pmara84 wants to merge 1 commit intocodebots-ltd:masterfrom
pmara84 wants to merge 1 commit intocodebots-ltd:masterfrom
Conversation
pmara84
commented
Feb 8, 2013
- The methods "decodeData:" and "decodeData:withError:" now return an NSInteger in order to remove compiler warnings.
- "elementName:" now recalls "elementName:error:" in order to clean up the code and remove the crash in case "aXMLElement" is nil.
- "attributeName:" now recalls "attributeName:error:" in order to clean up the code and remove the crash in case "aXMLAttribute" is nil.
- "attributeValue:" now recalls "attributeValue:error:" in order to clean up the code and remove the crash in case "aXMLAttribute" is nil. Moreover a new error code has been added "D_TBXML_ATTRIBUTE_VALUE_IS_NIL" (with its related error description "Attribute value is nil"), in order to avoid a crash in case the value of an attribute is nil.
- "textForElement:" now recalls "textForElement:error:" in order to clean up the code and remove the crash in case "aXMLElement" is nil.
- "valueOfAttributeNamed:forElement:" now recalls "valueOfAttributeNamed:forElement:error:" in order to clean up the code and remove the crash in case "aName" or "aXMLElement" are nil. Moreover a compiler warning has been removed in this method.
- "childElementNamed:parentElement:" now recalls "childElementNamed:parentElement:error:" in order to clean up the code and remove the crash in case "aName" or "aParentXMLElement" are nil.
- "nextSiblingNamed:searchFromElement:" now recalls "nextSiblingNamed:searchFromElement:error:" in order to clean up the code and remove the crash in case "aName" or "aXMLElement" are nil.
- removed compiler warnings - code cleanup
|
Please merge this instead of #14 , it's implemented quite well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.