Fix: Persist ExpandableText state across recomposition#18
Open
Sami00777 wants to merge 1 commit intocode3-dev:masterfrom
Open
Fix: Persist ExpandableText state across recomposition#18Sami00777 wants to merge 1 commit intocode3-dev:masterfrom
Sami00777 wants to merge 1 commit intocode3-dev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When users scrolled through the series list and returned to top of the screen, the text would collapse back to its truncated state. This occurred because
ExpandableTextwas using remember instead ofrememberSaveable, causing state to be lost when items left and re-entered the composition during list scrolling.Changes
expandedfrom remember torememberSaveableshowReadMorefrom remember torememberSaveableResult
Text expansion state now persists during list scrolling and configuration changes.
1.mp4