Skip to content

Conversation

@raphael-goetz
Copy link
Member

Resolves: #203

@raphael-goetz raphael-goetz marked this pull request as ready for review January 7, 2026 07:42
Copy link
Contributor

@nicosammito nicosammito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can not use

"dataTypeIdentifier": {
					"dataTypeIdentifier": "OBJECT"
				}
				

because the data type of Object is a generic Type. You need to provide a generic mapper

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds generic type support to OBJECT-related definitions by introducing generic keys and type mappers. The changes ensure that OBJECT types can properly represent their generic type parameters across runtime and data type definitions.

  • Adds generic type mappings with key "O" (or "T" for base OBJECT) to enable type parameterization
  • Updates runtime function definitions (size, set, keys, contains_key) to properly declare generic parameters
  • Refactors data type definitions to use generic type structures and removes redundant parentType rules

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
std_object_size.proto.json Adds generic type "O" with mapper to OBJECT parameter and declares it in genericKeys
std_object_set.proto.json Adds generic type "O" with mapper to OBJECT parameter and adds "O" to existing genericKeys alongside "I"
std_object_keys.proto.json Adds generic type "O" with mapper to OBJECT parameter and declares it in genericKeys
std_object_contains_key.proto.json Adds generic type "O" with mapper to OBJECT parameter and declares it in genericKeys
object.proto.json Introduces base generic type "T" with parentType rule and declares it in genericKeys
http_response.proto.json Updates body field to use generic OBJECT structure and removes redundant parentType rule
http_request.proto.json Updates body field to use generic OBJECT structure and removes redundant parentType rule
http_header_entry.proto.json Removes redundant parentType rule (no generic types needed)
rest_adapter_input.proto.json Updates body field to use generic OBJECT structure, removes parentType rule, and adds "O" to genericKeys

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@raphael-goetz raphael-goetz merged commit 11941e0 into main Jan 8, 2026
5 checks passed
@raphael-goetz raphael-goetz deleted the 203-missing-object-rules branch January 8, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing ParentTypeRule in OBJECT

3 participants