[pull] master from supabase:master #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#42290) ## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## What kind of change does this PR introduce? Reverting commit due to high error rates
## Context Started to notice a spike of this error happening on Sentry: `TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.` Checking the stack trace points the error to `cmdk` - the most recent change related to `cmdk` was this PR [here](#42277) ^ Not entirely suer if it was the cause tbh but it did help pinpoint the error locally that it was happening when trying to search in the `ColumnType` popover From what I can tell - it's happening because of the `CommandItem` "Other types" being rendered outside of a `CommandGroup` Am removing that as the fix + add `heading` to the `CommandGroups` so that it looks nicer anyways <img width="506" height="333" alt="image" src="https://github.com/user-attachments/assets/34623cfa-39be-4a02-9579-15303d442794" /> ## To test Can reproduce by trying to search in the ColumnType of the table side panel editor <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Improvements** * Enhanced the column type selector with better visual organization. Data types are now grouped into clearly labeled sections ("Postgres data types" and "Other types") with visual separators, making it easier to navigate and select the appropriate column type when editing tables. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Safer error rendering across analytics and reporting with a fallback "Unknown error". * **Tests** * Added unit tests covering timeseries sorting and timestamp validation. * **Refactor** * Standardized timeseries hook and all callers to accept a single options object and improved nullish handling. * **New Features** * Exposed timeseries utilities and explicit options/result types; exported chart data type. * **Chores** * Relaxed index signatures to allow dynamic metric keys. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## What kind of change does this PR introduce? Align Restore to New Project timestamps with Scheduled Backups by showing UTC, full date format, and consistent monospace styling ## What is the current behavior? Restore to New Project shows local time instead of UTC by default + style ## What is the new behavior? Unified the style, R2NP timestamp follows the Scheduled backup tab ## Additional context <details> <summary> before and after (dont judge my cropping skills) </summary> <br /> <img src="https://github.com/user-attachments/assets/3a43e970-79f1-4382-a61f-b36f5f8fe6d1" alt="CleanShot 2026-01-24 at 23 11 19"> </details> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Style** * Improved timestamp presentation in backup and restore screens: consistent UTC display, clearer label format (DD MMM YYYY HH:mm:ss (ZZ)), tighter monospace styling, and better alignment for enhanced readability and visual consistency. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )