[pull] main from adobe:main #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9123) * usePress: check hasPointerCapture before releasePointerCapture * improve test coverage * add same fix to useCalendarCell --------- Co-authored-by: Reid Barber <reid@reidbarber.com>
* fix: store scroll pos when virtualized * fix: removed isVirtualized prop --------- Co-authored-by: Robert Snow <rsnow@adobe.com>
* fix(overlays): fix an edge case in hiding outside elements When working with WYSIWYG editors or similar components that mutate the dom, the order or dome mutations could be in a way that dom mutation observer is called for elements that are not yet appended to the modal dom at the time MutationObserver callback is called. This change adds a safe-guard for such cases, by checking if the target element is connected, as otherwise it will be considered outside the currently visible elements. * comment clarification --------- Co-authored-by: Alireza Mirian <saym@danskebank.com> Co-authored-by: Robert Snow <snowystinger@gmail.com>
* feat: allow customizing behavior of pressed state * feat: use new prop in S2 components * fix daterangepicker * rename prop * whitespace --------- Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Robert Snow <snowystinger@gmail.com> Co-authored-by: Reid Barber <reid@reidbarber.com>
* fix(docs): update tanstack start routing setup * Apply suggestion from @snowystinger * fix spacing * Apply suggestion from @snowystinger * include in S2 router docs --------- Co-authored-by: Robert Snow <snowystinger@gmail.com> Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Reid Barber <reid@reidbarber.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )