[pull] main from bvaughn:main #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed in a recent commit that you [removed some unused collections](5a11ea6#diff-53ce94c55647fe0f3addc83cf2298ca14ddac4b13403434adf6b6fa6cc9a4afbL15-L18) - they were only added to, never accessed. There was another instance of this, so I added sonarjs to eslint which has a nice check for unused collections. I would personally enable `sonarjs/no-small-switch`. There are instances of switches with only one case, but I know this is some people's preference to keep a clean history, especially if they anticipate additional cases being added later. Likewise I'd enable `sonarjs/no-nested-conditional` but I left it off in case you prefer this style. `@types/sharp` was removed for an unrelated reason: ``` WARN deprecated @types/sharp@0.32.0: This is a stub types definition. sharp provides its own type definitions, so you do not need this installed. ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )