[pull] main from bvaughn:main #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regressed in PR #583 with the introduction of `height: 100%`. If `min-height` was used to set the Group's height (rather than an `!important` height override) then Panels would not fully fill the available space in Safari. This [Stack Overflow comment](https://stackoverflow.com/questions/8468066/child-inside-parent-with-min-height-100-not-inheriting-height) explains the reason why: > An element grows in height as much as required by its inner content. In such a situation, if the child also says I should have 100% height of my parent (through height:100%), it becomes a deadlock - parent height dependent on child, child height dependent on parent's. This deadlock cannot be resolved by the browser and so height:100% simply doesn't works...unless the parent as a resolvable height - one way to do which is by giving an explicit height to parent This PR fixes that by essentially switching the inner Panel element to use `flex-grow: 1` rather than `height: 100%` Resolves #619
Resolves #621
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )